Re: Delete-unused-code-TypeDescriptor_Init_Impl.patch

On 04/25/2012 10:48 PM, Stephan Bergmann wrote:
> On 04/25/2012 05:29 PM, Caolán McNamara wrote:
> > On Wed, 2012-04-25 at 00:11 +0100, José Santiago Jiménez Sarmiento
> > caolanm->sbergman: That leaky TypeDescriptor_Init_Impl is back to haunt
> > you. What would you prefer ?, use it, loose it, hide it ?
>
> #libreoffice-dev:
> Jan 05 12:02:47 <CIA-106> LibreOffice (core) sbergman *
> cppu/source/typelib/typelib.cxx: Leak TypeDescriptor_Init_Impl to avoid
> problems at exit.
> Jan 05 12:16:33 <caolan> sberg: what "problems on exit" ?, its a bit
> vague :-)
> Jan 05 13:02:19 <sberg> caolan, the typedescription data not having
> proper lifetime control (although it uses refcounting), e.g., static
> Sequence s_pType being used after the pointed-to
> TypeDescriptionReference has already been destroyed
> Jan 05 13:03:35 <sberg> caolan, ...seems to be related to my
> gbuild-cppuhelper changes of always emitting comprehensive data for
> certain UNO types, but why exactly the one causes the other escapes me
>
> Have to look at that again, I guess...

Sigh, running a couple "make check" with that "Leak 
TypeDescriptor_Init_Impl" commit reverted locally no longer showed any 
problems here.  So I just pushed the revert now.  (And thus made 
~TypeDescriptor_Init_Impl become used again.)

Stephan