Re: [PUSHED] Some fixes for Clang warnings

Catalin Iacob <iacobcatalin -AT- gmail.com>
Tue, 24 Apr 2012 23:26:37 +0200

On Mon, Apr 23, 2012 at 2:39 PM, Stephan Bergmann <sbergman@redhat.com> wrote:

Only 0002-WaE-Clang-unused-variable.patch and
0003-WaE-Clang-unused-variable.patch I did not push.  Can you change them as
I suggested above (or just let me know if you want me to do that)?


I attached updated patches which use SAL_WARN_IF instead of
OSL_ENSURE, warnings are indeed gone and hopefully the messages are a
bit better than before.

The 3rd one links to the CLucene patch proposed upstream as you suggested.

Attachment: 0001-WaE-Clang-unused-variable.patch
Description: Binary data

Attachment: 0002-WaE-Clang-unused-variable.patch
Description: Binary data

Attachment: 0003-Mention-that-the-CLucene-patch-was-also-sent-upstrea.patch
Description: Binary data

Context

Re: [PATCH] Some fixes for Clang warnings · Stephan Bergmann
- Re: [PUSHED] Some fixes for Clang warnings · Stephan Bergmann
  - Re: [PUSHED] Some fixes for Clang warnings · Catalin Iacob
    - Re: [PUSHED] Some fixes for Clang warnings · Lubos Lunak
      - Re: [PUSHED] Some fixes for Clang warnings · Stephan Bergmann
  - Re: [PUSHED] Some fixes for Clang warnings · Catalin Iacob
    - Re: [PUSHED] Some fixes for Clang warnings · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.