Re: [PUSHED][PATCH] WaE fixed in crashrep and extensions modules

On Sat, 2012-04-21 at 15:50 +0200, David Ostrovsky wrote:
> Hi,
>
> I'm getting build errors in crashrep and extensions modules (whith 
> enabled --enable-werror option).
> With these patches the warnings/errors are fixed.

Looks good, pushed, thanks for these. 

I wonder why *I* didn't see them before though seeing as I build with
-Werror. crashrep is disabled by default, so that's understandable, but
the scanner stuff in extensions is built by default and I've got...

export CFLAGS="-Wp,-D_FORTIFY_SOURCE=2 -fstack-protector
--param=ssp-buffer-size=4"
export CXXFLAGS="-Wp,-D_FORTIFY_SOURCE=2 -fstack-protector
--param=ssp-buffer-size=4"
export ARCH_FLAGS="-Wp,-D_FORTIFY_SOURCE=2 -fstack-protector
--param=ssp-buffer-size=4"

in my (Fedora 16) environment to generally get those extra warnings (I
thought). I knew that e.g. Ubuntu configured gcc to add some extra
warnings etc by default, but I had thought the above covered those
additions. Wonder what I'm missing to get your warnings ?, i.e. what's
your compiler version and distro ?

For the second patch I added a follow up commit of
e37ae322b07a02714b22cb663e1d7ab4f2072730 to fill in the "todos". e.g. I
reckon it's best to compare how many bytes/members were written/read
with write/read fread/fwrite vs what was requested to detect partial
failure short read/write as well as the added detection of out and out
utter failure.