Hi there,
It's a nice patch :-) however - I believe that Lubos just did a chunk
of work to make this even easier to read, such that we can do:
- if ( m_nxtSym == OUString(RTL_CONSTASCII_USTRINGPARAM( "\"" )) )
+ if ( m_nxtSym == "\"" )
Which will turn into something like:
+ if ( m_nxtSym.equalsAsciiL(RTL_CONSTASCII_USTRINGPARAM( "\"" )) )
But be a lot shorter :-) any chance you can adapt your patch to that
style ? [ it'd be good to fix other instances of this specific wasteful
temporary around the place too ].
It'd be great to have a blanket license mail on the list we can link
into:
http://wiki.documentfoundation.org/Development/Developers
If that's possible :-)
Thanks !
Michael.
--
michael.meeks@suse.com <><, Pseudo Engineer, itinerant idiot
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.