Re: [Libreoffice-commits] .: writerfilter/source

On Tuesday 17 of April 2012, CaolXXn McNamara wrote:
>  writerfilter/source/dmapper/GraphicHelpers.cxx |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> New commits:
> commit b92de73fdd81acc5fdb92005af34b3ce9f8ed37b
> Author: Caolán McNamara <caolanm@redhat.com>
> Date:   Tue Apr 17 20:11:20 2012 +0100
>
>     WaE: MacOSX itemZOrder may be unused uninitialized

 Weeeell, that's clearly not true, and recent gcc version does not warn there. 
Norbert, could you please turn off the --enable-werror on that tinderbox? 
There's not much point in trying to please the whims of such an old compiler.

> diff --git a/writerfilter/source/dmapper/GraphicHelpers.cxx
> b/writerfilter/source/dmapper/GraphicHelpers.cxx index 819dc6f..551c5e9
> 100644
> --- a/writerfilter/source/dmapper/GraphicHelpers.cxx
> +++ b/writerfilter/source/dmapper/GraphicHelpers.cxx
> @@ -240,7 +240,7 @@ sal_Int32 GraphicZOrderHelper::findZOrder( sal_Int32
> relativeHeight ) {
>          if( items.empty())
>              return 0;
> -        sal_Int32 itemZOrder;
> +        sal_Int32 itemZOrder(0);
>          --it;
>          if(
> it->second->getPropertyValue(PropertyNameSupplier::GetPropertyNameSupplier(
> ) .GetName( PROP_Z_ORDER )) >>= itemZOrder )

-- 
 Lubos Lunak
 l.lunak@suse.cz