Hey Miklos,
On Sun, Apr 15, 2012 at 03:16:35AM +0200, Artur Dorda <artur.dorda@gmail.com> wrote:
This patch is transferring XPrintAreas test to c++, from
qaDevOOo/tests/java/ifc/sheet to test/inc/test/ and test/source/
Great!
Though not all tests are transferred, I'm sending this so it could be
reviewed, because it's my first patch and changes 5 files.
Is there any reason why didn't remove the replaced java code from
qadevOOo?
This was my decision. The qaDevOOo tests have no clean dependencies so
I prefer if we don't remove them and just disable the test in
knownissues.xcl or module.sce. As soon as no test from one module are
executed any more we can safely remove the corresponding directory in
qaDevOOo, otherwise we run into some strange runtime crashes.
Regards,
Markus
P.S. I will review the patch this evening.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.