Re: [REVIEW:3-5]patches for 35 MAB fdo#45376 already in master ..

On 16/04/12 09:49, Petr Mladek wrote:
> Cor Nouws píše v Ne 15. 04. 2012 v 16:08 +0200:
> > Hi,
> >
> > I see Bug 45376 - [FORMATTING] Incorrect text wrapping around drawing
> > shape, one of the 3.5 MAB issues, that seems to be fixed with two
> > commits in master, according to comment 4 (
> > https://bugs.freedesktop.org/show_bug.cgi?id=45376#c4 )
> It is about these two commits:
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=b446a1fb30b5a7097824acfe6bbbb143f4284b03
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=84370b807279cd8336c3e77278bae42b904324b4
>
> > Could pls be considered to push these patches to 3.5 branch too?
> Noel, you pushed them into master. Do you still remember them? Are they
> safe for 3-5? It looks like to me :-)
ok I remember this, it was a problem ( to do with text wrapping around a 
shape ) that only showed in the preview I think. The fix however was to 
the (mystery) layout code and I am not sure if that code is specific to 
the preview or not. At the time it didn't seem ( to me ) the problem was 
serious enough to risk 3.5, I guess I'd be happier if Michael or some 
other writer knowledgeable person gave a blessing...

Noel