Re: [Pushed] Easy Hack Bug No. 42982

On 11/04/12 21:20, Abeer Sethi wrote:
> I'm attaching the patch for namecont.cxx, I hope this is the correct way
> to go about it. If yes, I have another patch ready for another file.
>
> Thanking You,
> Abeer Sethi.

hello Abeer,

thanks for sending this patch.

but in addition to the points that Stephan raised, there are some things
you could improve:

first, the subject of the mail contains [Pushed], but that is the tag
used to indicate that a patch has been integrated.
if you send a patch to the list for others to review, then you should
use the [PATCH] tag instead.

second, the subject of the attached patch:

> Subject: [PATCH] Author: Abeer Sethi (abeersethi@gmail.com) Date: Thur Apr 12
>  00:29 2012 +0530 Fixes bug 42982

please refer to freedesktop.org bugs with the notation "fdo#42982".

also, you do not need to include the author or date in the subject line,
as you can see git already automatically adds special headers that
include this data:

> From: Abeer Sethi <abeersethi.91@gmail.com>
> Date: Thu, 12 Apr 2012 00:28:10 +0530

please try again by send a new patch with the raised points corrected :)

regards,
 michael