On Tue, 2012-04-10 at 09:43 +0200, Miklos Vajna wrote:
On Sat, Apr 07, 2012 at 09:15:30PM +0200, Gábor Stefanik <netrolller.3d@gmail.com> wrote:
Hm, are you sure this is right, without removing the
Underline attribute from oovbaapi/ooo/vba/XFontBase.idl? (But simply
removing an attribute from there may break the ABI, I'm not sure.)
It definitely does compile and run for me - however, if you mean it
may cause regressions in functionality, then why is this in
unusedcode.easy?
The easy suffix just means the function name is not something you can
easily dlopen().
This one falls under note "c" of unusedcode.README. They are pure
virtuals (the = 0 in the declaration), and no-one is explicitly calling
the pure virtual impls. Seeing as a VbaFontBase cannot be instantiated,
something has to inherit from it and provide an implementation of those
pure virtuals, and its those implementation in the inherited classes
that will get called.
So, upshot is that the right fix is to drop the unused base-class
implementation of the pure-virtual, i.e.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=231520e7bb996f5ec211ff7e4f64e20f112d8789
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.