Re: problem with compiling and linking the same file into different libraries

Hey,

2012/4/10 Michael Stahl <mstahl@redhat.com>:
> On 08/04/12 18:48, Lubos Lunak wrote:
> > On Sunday 08 of April 2012, Markus Mohrhard wrote:
> > > There are currently 2 related problems. First the check for duplicated
> > > linked objects complains that cursormove.o is linked into two libs and
> > > then David pointed out that cursormove.cxx is only compiled once with
> > > my current approach. So one of the two makefiles uses an object file
> > > that uses the wrong header files.
> >
> >  That is actually only one problem, the complaint is there because of this
> > (https://bugs.freedesktop.org/show_bug.cgi?id=47246). And I suppose the
> > solution is the same, e.g. do cursormove.cxx in qa/ that does #include
> > <real_cursormove.cxx> .
>
> indeed, just adding the same source file in 2 different link targets
> only happens to work in very special cases, and definitely not in this
> case.  perhaps it would make sense to #include the core cxx file
> directly in the cppunit test cxx file?

I used this right now. Will see if I run into problems with this later.

> >  PS: I think you didn't want to include the solenv/gbuild/LinkTarget.mk change
> > in the patch.
>
> i hope he didn't :)
No. the patch was just a dump of all changes in my working branch. It
included much more wron or incomplete changes.

Markus