Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Sunday 01 of April 2012, Rafael Dominguez wrote:
More cleanup of deprecated class List, need to be pushed after part1 and in
order.
Thanks! Please read carefully

 It seems nobody has handled this yet. I have checked the patches and they 
look good to me, except for one thing that I'd like to clear up before 
committing. The patches do changes like this:

     List*                   GetSelectEntryList( sal_uInt16 nDepth );                               
                         
+    void                    GetSelectEntryList (sal_uInt16 nDepth, 
std::vector<rtl::OUString> &rEntries) const;             

 Why is that? Changing the return value to a reference argument makes the API 
worse and it seems like an unnecessary change to me.

-- 
 Lubos Lunak
 l.lunak@suse.cz

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.