Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Sunday 08 of April 2012, julien2412 wrote:
Hello,

On master repo, cppcheck reported this :
[writerfilter/source/filter/ImportFilter.cxx:227] ->
[writerfilter/source/filter/ImportFilter.cxx:227]: (style) Same expression
on both sides of '||'
...
So because of the 2 things noticed, I think there should be both and so
just replace "1" by "2" and have "SERVICE_NAME2" as second operand.

Perhaps I'm wrong or missed something, any idea ?

 No, your analysis looks correct to me, feel free to push the fix.

-- 
 Lubos Lunak
 l.lunak@suse.cz

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.