Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Thu, 2012-04-05 at 14:39 +0200, Lubos Lunak wrote:
On Thursday 05 of April 2012, Caolán McNamara wrote:
On Thu, 2012-04-05 at 08:43 +0300, Tor Lillqvist wrote:
if (foo.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM("XXXXX")))
if (foo.equals(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("XXXXX"))))

can be written as

if( foo == "XXXXX" )

This has to be the biggest improvement in OOo/LO codebase readability
ever! Incredibly nice!

Look good. I wonder though if its only me that would prefer not to have
an overloaded operator== and to force bar.equalsfoo("").

 Quite possibly yes :). Why would you want the explicit less convenient way?

Cause I worry that someone's going to end up comparing string literals
to each other under some conversion like

-#define FOO rtl::OUString(..."foo"...)
+#define FOO "foo"
-#define BAR rtl::OUString(..."bar"...)
+#define BAR "bar"

if (FOO == BAR)

C.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.