On 04/04/2012 08:51 AM, Lubos Lunak wrote:
On Wednesday 04 of April 2012, Daniel Bankston wrote:
Lubos Lunak wrote:
It seems to me you are correct. I've added !IsEmpty() check to the if(),
which should do what the original author wanted.
I'm still a little worried about that aClip object that is being
intersected with aRegion which is now on line 673 but was originally in the
conditional on the line below. The reason I'm worried is because the aClip
object is used again on line 697. I don't know if the original author knew
that he/she was intersecting aClip with aRegion on line 673. So what I'm
asking is: Should we completely remove SetClipRegion( aClip ) on line 673?
I'm not familar with the code, but I think the current version is correct
(and it matches what the previous code did, since 2002). It looks to me that
aRegion is the clipping region for the entire operation and so clipping each
of the iterations by it too should be correct.
Ok, I'll leave it be then. Thanks for pushing and looking at it!
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.