Hey,
I'm submitting a patch for the easy hack 39749. I have written one test that
tests the setbackgroundcolor function in ScDocFunc class
Great to have you working on this, I have just some small comments:
- Could you please build with your patch before submitting? The patch
was in several ways broken and I had to fix it to get it build.
- Can you set your git settings so that it sets the author name
correctly. I adjusted it in your patch.
- You still had trailing whitespaces in your commit. Can you try to
set-up your editor to remove them or remove them when our git hook
complains about them?
Except for these smaller problems the patch was good and I pushed it
with my small modifications.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=3d86e4e7223b15d561d1efdac736e932ea41e6a0
Can you confirm that your patch is under MPL/LGPLv3+?
Regards,
Markus
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.