Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi Noel,

pushed after all (phew!) :) Added some corrections in the subsequent commits - see the git log.

But I wonder why in the following code... (chartpos.cxx:548)

            RowMap::const_iterator pPosIter = pCol2->begin();
            if ( pPosIter != pCol2->end() )
            {
                if ( nRowAdd )
                {
ppColHeader[ nCol ] = pPosIter->second; // eigenstaendig
                    ++pPosIter;
                }
                else
                    ppColHeader[ nCol ] = pPosIter->second ?
                        new ScAddress( *pPosIter->second ) : NULL;
            }

...pPosIter is not incremented in the else branch. I know - that logic was here before the conversion to std::map. But it looks weird...

Anyway, thank you for this work!

Ivan

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.