Hi there,
I'd like to have the attached patch applied for the 3-5 and possibly for
the 3-5-2 branch as well.
It fixes
https://bugs.freedesktop.org/show_bug.cgi?id=46942
It's actually a very old regression, as the responsible commit goes back
to May of 2011. But it was only recently discovered & reported.
To me this is a very safe change, caused by simple oversight. I'd like
to have this pushed to 3-5, and possibly 3-5-2 if people agree.
Master has the same fix already, but because I did some cleanup before
fixing the bug, it made my fix non-backportable without some adjustment.
Anyway,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
From 74b40d32f8e034b0f2d0cc9ecffdd11f5f9f54ab Mon Sep 17 00:00:00 2001
From: Kohei Yoshida <kohei.yoshida@gmail.com>
Date: Mon, 26 Mar 2012 16:26:32 -0400
Subject: [PATCH] fdo#46942: Fix a regression caused by List removal.
3236c2c3af9355157c62f68fcbd429498f7f747b accidentally removed the gallery
item count which was used to differentiate the gallery symbols from
normal ones.
---
cui/source/tabpages/tpline.cxx | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/cui/source/tabpages/tpline.cxx b/cui/source/tabpages/tpline.cxx
index 3a27eaa..abb5df3 100644
--- a/cui/source/tabpages/tpline.cxx
+++ b/cui/source/tabpages/tpline.cxx
@@ -1464,6 +1464,7 @@ IMPL_LINK( SvxLineTabPage, MenuCreateHdl_Impl, MenuButton *, pButton )
String aEmptyStr;
const String *pUIName = NULL;
sal_uInt32 i = 0;
+ nNumMenuGalleryItems = aGrfNames.size();
for(std::vector<String>::iterator it = aGrfNames.begin(); it != aGrfNames.end(); ++it, ++i)
{
pUIName = &(*it);
--
1.7.3.4
Context
- [REVIEW 3-5] Fix for fdo#46942. · Kohei Yoshida
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.