Re: [PUSHED:3-5] graphical query editor mangles sorting order

Petr Mladek <pmladek -AT- suse.cz>

Tue, 20 Mar 2012 12:43:48 +0100

Lionel Elie Mamane píše v Út 20. 03. 2012 v 11:30 +0100:

Attached patch fixes (old! at least back to 3.3) bugs exposed by
fixing fdo#46843, about sort orders in the graphical query editor:

fdo#47370: when sort columns order does not match result columns
           order, sort is reordered to result order

         E.g. "SELECT a, b, c FROM foo ORDER BY c, a"
           becomes "SELECT a, b, c FROM foo ORDER BY a, c"

fdo#47560: when several sort columns are "out of result order", all
           are set to the last

         E.g. "SELECT a, b, c FROM foo ORDER BY c, a, b"
         becomes "SELECT a, b, c FROM foo ORDER BY c, b, b"

         That is simply because those "additional" sort columns were
         set in the *same* in-memory structure. Fix: allocate a
         fresh structure for each new sort column.

Great catch! Both fixes make sense and work like a charm. I have pushed them into 3-5 branch. They will be in 3.5.2. Best Regards, Petr

Context

[PATCH] [REVIEW:3-5] graphical query editor mangles sorting order · Lionel Elie Mamane

Re: [PUSHED:3-5] graphical query editor mangles sorting order · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.