Re: [PATCH] fdo#84393: Title field displays wrongly in header/footer

Hi *,

2012/3/15 Korrawit Pruegsanusak <detective.conan.1412@gmail.com>:
> 2012/3/15 Dézsi Szabolcs <dezsiszabi@hotmail.com>:
> > I made a patch for this
> > (https://issues.apache.org/ooo/show_bug.cgi?id=84393). It was present in LO
> > too.
>
> I didn't look at the code yet, but please apologize my nitpicking: the
> openoffice bugzilla is referred as i#84393

Well, there was no reference to the bug in the patch, and of course
full URLs are appreciate here.

But to correct your nitpicking: the traditional way to refer to the
OOo bugtracker was #i1234
[cl@esprimo lo-core]$ git log | grep '#i[1-9]'  |wc -l
258646
[cl@esprimo lo-core]$ git log | grep 'i#[1-9]'  |wc -l
1026

But I agree with:
> And, could you please also mention the bug number in the subject of
> commit message too? Thanks again.

Yes, when a concrete bug is fixed, it should be mentioned in the commitlog.

ciao
Christian