Re: -Wno-non-virtual-dtor

Stephan Bergmann <sbergman -AT- redhat.com>
Thu, 15 Mar 2012 08:24:18 +0100

On 03/13/2012 02:24 PM, Stephan Bergmann wrote:

[1] There might be a way around that after all, adding a non-virtual,
protected destructor to the C++ classes representing UNO interfaces.
Will look into that.

[2] <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7302>
"-Wnon-virtual-dtor should't complain of protected dtor" apparently
solves the problem for cppuhelper/propertysetmixin.hxx that originally
caused problems. Seems to be available at least in the Fedora-16 GCC
4.6.2. (And -Wall appears to no longer automatically enable
-Wnon-virtual-dtor.) Maybe all this allows us to re-enable
-Wnon-virtual-dtor after all; will look into that.

FTR, done this now as<http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e67c03dc0225fc66343546b14e902b9d238b1a3>"Enable -Wnon-virtual-dtor for GCC 4.6" and<http://cgit.freedesktop.org/libreoffice/binfilter/commit/?id=c599fdba10c210ecf3f94119cb1138f3846320df>"Adapted to -Wnon-virtual-dtor enabled for GCC 4.6".


Stephan

Context

-Wno-non-virtual-dtor · Tor Lillqvist
- Re: -Wno-non-virtual-dtor · Stephan Bergmann
  - Re: -Wno-non-virtual-dtor · Lubos Lunak
    - Re: -Wno-non-virtual-dtor · Stephan Bergmann
      - Re: -Wno-non-virtual-dtor · Arnaud Versini
  - Re: -Wno-non-virtual-dtor · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.