Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi David,

actually, your fix was my first attempt to solve the bug. It solved the UI problem, I remember. And then I decided to clean-up the code a bit... You might see my patch. :)

But I cannot ever understand, how it fixes the real problem (setting paper tray). https://bugs.freedesktop.org/show_bug.cgi?id=43932#c17 says that it is not a GUI-problem...


Technically:

The call chain is

  printFilteredPage -> getFilteredPageFile -> getPageFile -> modifyJobSetup

where modifyJobSetup sets a paper tray, taking in account a tray that was set for a single page; and then there is the following code inside printFilteredPage

    if( mpImplData->mnFixedPaperBin != -1 &&
mpImplData->mpPrinter->GetPaperBin() != mpImplData->mnFixedPaperBin )
    {
        mpImplData->mpPrinter->SetPaperBin( mpImplData->mnFixedPaperBin );
    }

which sets a paper tray again. (?)

In my patch I used mpImplData->mpPrinter->GetPaperBin() in printFilteredPage to control what tray is currently used, and that showed right trays. So I am confused. %-)

Regards,
Ivan

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.