Re: libcmis patch (was: [Libreoffice-commits] .: Enable -Wnon-virtual-dtor for GCC 4.6)

Hi Stephan

On Wed, 2012-03-14 at 14:50 +0100, Stephan Bergmann wrote:
> > diff --git a/libcmis/libcmis-0.1.0-non-virtual-dtor.patch 
> > b/libcmis/libcmis-0.1.0-non-virtual-dtor.patch
> > new file mode 100644
> > index 0000000..764c7b2
> > --- /dev/null
> > +++ b/libcmis/libcmis-0.1.0-non-virtual-dtor.patch
> > @@ -0,0 +1,11 @@
> > +--- misc/libcmis-0.1.0/src/libcmis/cmis-object.hxx 2011-09-30 20:35:37.000000000 +0200
> > ++++ misc/build/libcmis-0.1.0/src/libcmis/cmis-object.hxx   2012-03-13 21:46:03.985188599 +0100
> > +@@ -39,6 +39,8 @@
> > +     class CmisObject
> > +     {
> > +         public:
> > ++            virtual ~CmisObject() {}
> > ++
> > +             virtual std::string getId( ) = 0;
> > +             virtual std::string getName( ) = 0;
> > +
>
> Cedric, can you upstream this?  (Or even make the dtor non-inline, to 
> reduce the amount of symbols with vague linkage -- but I did not find a 
> fitting .cxx to put it into.)

This is already in the upstream repository in the master branch, but it
seems I forgot to backport the patch to the version used by LibreOffice:

http://sourceforge.net/p/libcmis/code/ci/822840832921b03f12511d747b39cea34aca023a/tree/src/libcmis/object.hxx?diff=0c1794a03e90cb3c6bb6d861112089cea1fa68e2

Thanks for the fix.

--
Cedric