Re: [PATCH] convert tools/table.hxx to std::map in ScEEParser class in SC module

Noel Grandin <noel -AT- peralex.com>
Wed, 14 Mar 2012 14:02:23 +0200

Hi

Updated patch attached.

Thanks, Noel Grandin

On 2012-03-12 14:33, Ivan Timofeev wrote:

Hi Noel,

 for ( SCCOL nCol = nStartCol; nCol <= nEndCol; nCol++ )
 {
-   sal_uInt16 nWidth = (sal_uInt16)(sal_uLong) pColWidths->Get( nCol );
+   sal_uInt16 nWidth = 0;
+   if ( rColWidths.find( nCol ) != rColWidths.end() )
+      nWidth = rColWidths[ nCol ];

so this code performs a search twice - firstly 'find', then'operator[]'. And it is in the loop. And it is an import filter. Maybe


  iterator it = rColWidths.find( nCol );
  if ( it != rColWidths.end() )
     nWidth = it->second;

is better? Or I am missing smth.?

Regards,
Ivan


Disclaimer: http://www.peralex.com/disclaimer.html

Attachment: 0001-Convert-tools-table.hxx-to-std-map-in-ScEEParser-cla.patch
Description: application/mbox

Context

[PATCH] convert tools/table.hxx to std::map in ScEEParser class in SC module · Noel Grandin
- Re: [PATCH] convert tools/table.hxx to std::map in ScEEParser class in SC module · Ivan Timofeev
  - Re: [PATCH] convert tools/table.hxx to std::map in ScEEParser class in SC module · Noel Grandin
    - Re: [PUSHED][PATCH] convert tools/table.hxx to std::map in ScEEParser class in SC module · Ivan Timofeev

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.