Re: [REVIEWED][REVIEW 3-5] fdo#45543 fix RTF import of ms932-encoded characters

Stephan Bergmann <sbergman -AT- redhat.com>
Tue, 13 Mar 2012 11:26:56 +0100

On 03/13/2012 09:41 AM, Miklos Vajna wrote:

On Mon, Mar 12, 2012 at 01:40:07PM +0000, Caolán McNamara<caolanm@redhat.com>  wrote:

Doesn't really matter, but in the ctor member init lists, there isn't
really a need to call the default ctors explicitly, e.g.
, m_aUnicodeBuffer()
, m_aHexBuffer()
could just be left out


OK, I'll keep that in mind for new code. I just remember at least once I
left out something similar, got no local warnings, but the OSX -Werror
tinbuild failed.

IIRC, this sometimes happens with copy ctors, when for some reasondefault initialization of a base or member would be fine (so could beleft out), but some compilers would warn about the copy ctor notexplicitly initializing a base or member.


Stephan

Context

[REVIEW] fdo#45543 fix RTF import of ms932-encoded characters · Miklos Vajna
- Re: [REVIEWED][REVIEW 3-5] fdo#45543 fix RTF import of ms932-encoded characters · Caolán McNamara
  - Re: [REVIEWED][REVIEW 3-5] fdo#45543 fix RTF import of ms932-encoded characters · Miklos Vajna
    - Re: [REVIEWED][REVIEW 3-5] fdo#45543 fix RTF import of ms932-encoded characters · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.