Re: [PATCH] [PUSHED] Possible memory leak in RTFValue

Miklos Vajna <vmiklos -AT- suse.cz>

Sun, 11 Mar 2012 21:49:31 +0100

Hi Arnaud, On Sun, Mar 11, 2012 at 08:56:00PM +0100, Arnaud Versini <arnaud.versini@gmail.com> wrote:

I'm not sure but Valgrind said that memories allocations in RTFValue are
not deleted, so this patch make Value's destructor virtual (parent of
RTFValue).

valgrind is right - the improvement is dramatic! With a testdoc from fdo#38057, the memory usage after import is 1.8g -> 121m here. Pushed to master and libreoffice-3-5. Thanks! Miklos

Context

[PATCH] [REVIEW] Possible memory leak in RTFValue · Arnaud Versini

Re: [PATCH] [PUSHED] Possible memory leak in RTFValue · Miklos Vajna

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.