Re: [Libreoffice-commits] .: Makefile

On Wed, Mar 7, 2012 at 10:16 AM, Matúš Kukan <matus.kukan@gmail.com> wrote:
> On 27 February 2012 09:28, Norbert Thiebaud <nthiebaud@gmail.com> wrote:
> > > @@ -342,12 +342,15 @@ ifneq ($(filter-out clean distclean,$(MAKECMDGOALS)),)
> > >  # restart since autogen can have changed
> > >  # config_host.k which is included in this
> > >  # Makefile
> > > -Makefile: config_host.mk
> > > +Makefile: $(SRCDIR)/config_host.mk
> >
> > why did you have to add $SRCDIR here ?
> > Makefile has to be run in the top dir... and if not the dependencies below would not be found 
> > (config_host.mk.in for
> > instance)
>
> > > +autogen.lastrun:
> > > +     @true
>
> I also don't understand how could autogen.lastrun not exist when
> config_host.mk is already required and both are created by autogen.sh ?

The only scenarii I can think of are:

make jsut after clone without autogen first
make disclean without autogen afterward

in both case, a user error I think... we could add a $(error in case
config_host.mk is not there to tell more clearly to the user that he
is being silly.

Norbert