[REVIEW 3-5-1] fix for fdo#46816, don't show error message for empty range name in Define Names

Michael Meeks <michael.meeks -AT- suse.com>
Mon, 05 Mar 2012 11:27:11 +0000


On Fri, 2012-03-02 at 22:18 -0500, Kohei Yoshida wrote:

[1] improves the dialog a bit. The error message is a bit misleading
and we can just use the disabled Add button as sign that you can't add
an empty range name.

[1] 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e93e78c85e0c4eea174483f1d27ee38fd00ee21


The change makes sense & is safe.  Pushed to the 3-5 branch with my sign-off.


        You have a #2 from me - looks trivial & safe for -3-5-1.

        Thanks,

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot

Context

[REVIEW] fix for fdo#46816, don't show error message for empty range name in Define Names · Markus Mohrhard
- Re: [REVIEWED] [PUSHED 3-5] fix for fdo#46816, don't show error message for empty range name in Define Names · Kohei Yoshida
  - [REVIEW 3-5-1] fix for fdo#46816, don't show error message for empty range name in Define Names · Michael Meeks
    - Re: [PUSHED][REVIEW 3-5-1] fix for fdo#46816, don't show error message for empty range name in Define Names · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.