Re: [REVIEW 3-5] Custom Shapes compile speedup ...

Hi again,

On Fri, 2012-03-02 at 19:51 +0100, Radek Doulik wrote:
> Hi Michael,
>
> thanks. The patch looks good to me. Pushed.
>
> It doesn't change the properties data, so it shouldn't break anything. I
> guess I will cook another sample document containing all presets for
> easier future testing.

pushed change to PPTXs generator. We now generate preset-cshape-*.pptx
documents as well, which might come handy when testing. All the presets
indeed look OK, so I guess no harm was done ;-)

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e3c0a952a7607436224fe57f9e1665597702f6b2

Cheers
Radek

> Cheers
> Radek
>
> On Fri, 2012-03-02 at 17:44 +0000, Michael Meeks wrote:
> > Hi guys,
> >
> >     I'd like to propose this for cherry-picking:
> >
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=f291fb57d087de41385a22dfacd8b694d8b9abc7
> >
> >     the rather large and tedious patch it generates is this:
> >
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=d4157cefc5416ebea75a460e7dbff91293bff321
> >
> >     Which also needs picking. Wrt. compile times here is what it does for
> > me:
> >
> >             Linux       Windows VM
> >     Before: 1m13.067s   23m10.179
> >     After:  0m16.993s    0m5.808
> >
> >     So - it really did turn out to be faster to fix than to compile ;-) Of
> > course, prolly I -totally- broke it, but it still loads the nice
> > customshapes-all document (at least for me) - I'd like Radek to review
> > it before we go anywhere.
> >
> >     I'm just poking to see if I can squeeze a bit more time & space out of
> > this, but I'm fairly confident that this is the major win.
> >
> >     HTH,
> >
> >             Michael.