Re: [PUSHED:3-4,3-5][REVIEW:3-5-1] fix crash using edit instance from xforms "Data navigator" dialog

Petr Mladek <pmladek -AT- suse.cz>
Thu, 01 Mar 2012 14:31:47 +0100

Michael Stahl píše v Čt 01. 03. 2012 v 13:52 +0100:

On 01/03/12 13:20, Noel Power wrote:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b860d4970604f08ebd2e818bfd63891dd940804

should fix the problem, it seems that commit 
f7f47366ea78a71853fcaca2fa402bef667d9cce introduced a 'delete(pPage);' ( 
it seems from the comment to silence some cppcheck error ) but that 
delete doesn't imo make any sense.


indeed that delete looks completely bogus, pushed to libreoffice-3-5:

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=369aea7f7402e9dc98e9347ae58999dad2d21652

2 more needed for -3-5-1


Looks fine to me. One more review needed for -3-5-1.


Best Regards,
Petr

Context

[REVIEW 3-5][REVIEW 3-5-1 ?] fix crash using edit instance from xforms "Data navigator" dialog · Noel Power
- Re: [REVIEW 3-5][REVIEW 3-5-1 ?] fix crash using edit instance from xforms "Data navigator" dialog · Michael Stahl
  - Re: [PUSHED:3-4,3-5][REVIEW:3-5-1] fix crash using edit instance from xforms "Data navigator" dialog · Petr Mladek
    - Re: [PUSHED:3-4,3-5][PUSHED:3-5-1] fix crash using edit instance from xforms "Data navigator" dialog · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.