Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi,

The nsplugin is broken in 3.4.5 and 3.5.0 - we just discussed this on IRC:

22:58 <@_rene_> mmh, I think the nsplugin is broken
22:58 <@_rene_> in both 3.4.5 and 3.5.0
22:59 <@_rene_> opens a separate LO window with *startcenter* instead of the document
22:59 <@_rene_> no idea, but...
22:59 <@_rene_>             mxRemoteMSF->createInstance( 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.ucb.SimpleFileAccessw")) ),
23:00 <@_rene_> looks fishy to me? shouldn't it just be com.sun.star.ucb.SimpleFileAccess?
23:01 -!- monsterzero [~monsterze@CPE5cd9985f2795-CM001bd7ad832c.cpe.net.cable.rogers.com] has 
joined #libreoffice-dev
23:02 -!- jtang613 [63e09c2f@gateway/web/freenode/ip.99.224.156.47] has joined #libreoffice-dev
23:02 < jtang613> Q: Why don't LO cli commands work when a gui LO instance is present?
23:03 <@sberg> _rene_, yep, 648589a0bd6c72b8b6b125644b43c6efad17ead1 typo
23:03 < IZBot> core - RTL patch - 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=648589a0bd6c72b8b6b125644b43c6efad17ead1
[...]
23:04 <@_rene_> sberg: ok...
23:05 <@_rene_> sberg: I  think this sounds like a -3-4 and 3-5-1 fix...
23:05 <@_rene_> will test and mail to ml...
23:05 <@sberg> _rene_, you can already count in my sign-off
23:07 <@_rene_> ok, so already signed-off for 3.5 at least ;-) -3-4 needs also 3? or just 1 as -3-5?
23:07 <@sberg> no idea :(
23:08 <@_rene_> we'll see
23:09  * _rene_ commits to master and -3-5 for now and mail the ml
23:09 <@_rene_> (verified that it fixed the plugin)

Trivial fix:

From 3d22544462e4fde4440d383c8792936df5f57990 Mon Sep 17 00:00:00 2001
From: Rene Engelhard <rene@debian.org>
Date: Wed, 29 Feb 2012 23:19:00 +0100
Subject: [PATCH] fix nsplugin to create correct com.sun.star.ucb.SimpleFileAccess instance

---
 extensions/source/nsplugin/source/so_instance.cxx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/extensions/source/nsplugin/source/so_instance.cxx 
b/extensions/source/nsplugin/source/so_instance.cxx
index b87b83f..8b243ae 100644
--- a/extensions/source/nsplugin/source/so_instance.cxx
+++ b/extensions/source/nsplugin/source/so_instance.cxx
@@ -239,7 +239,7 @@ sal_Bool SoPluginInstance::LoadDocument(NSP_HWND hParent)

         //create stream for the document
         Reference< ::com::sun::star::ucb::XSimpleFileAccess > xSimpleFileAccess(
-            mxRemoteMSF->createInstance( 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.ucb.SimpleFileAccessw")) ),
+            mxRemoteMSF->createInstance( 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.ucb.SimpleFileAccess")) ),
             uno::UNO_QUERY );
         if(!xSimpleFileAccess.is())
         {
--
1.7.2.5

Please sign-off for -3-5-1 and 3-4 (Q: does -3-4 need 1 or 3 reviews?)

Regards,

Rene

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.