[REVIEW][3-5][3-4] more problems in SwRootFrm dtor

Michael Stahl <mstahl -AT- redhat.com>

Wed, 29 Feb 2012 23:00:09 +0100

due to CWS swlayoutrefactoring there is another problem in SwRootFrm destruction, which has been found with valgrind: the children of the root frame are only destroyed by the base class destructors, so since every layout frame has a pointer to the SwRootFrm they may access its members after the SwRootFrm dtor has returned (valgrind complained about an invalid read of a freed SwRootFrm member). so refactor this a little to execute the base class dtors before SwRootFrm dtor returns: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ebb74441790a9852b1a1532d6e025c324666f6fc plus, valgrind also complained about this: http://cgit.freedesktop.org/libreoffice/core/commit/?id=f430b71c46186b53a6364a60b237c81245f3eabb

Context

[REVIEW][3-5][3-4] more problems in SwRootFrm dtor · Michael Stahl

Re: [PUSHED][3-5][3-4] more problems in SwRootFrm dtor · Miklos Vajna

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.