Re: [REVIEW 3-5][PATCH] Fix leap year calculation

Stephan Bergmann <sbergman -AT- redhat.com>
Wed, 29 Feb 2012 08:53:23 +0100

On 02/29/2012 04:10 AM, Kohei Yoshida wrote:

The attached patch fixes a bug in our current leap year calculation
code.  It is based on the algorithm posted on wikipedia[1], and seems to
correctly identify year 2000 as a leap year.

Without this, Calc would convert 2000-2-29 into 1899-12-30 on load,
which is ugly but very hard to detect.

Please consider this for 3.5.1, in which case I'll need 3 sign-offs.  I
haven't pushed this to master yet.  I wanted to run it by Eike first
before pushing to master.


You can count me in as +1 towards pushing it to all the relevant branches.

Stephan

Context

[REVIEW 3-5][PATCH] Fix leap year calculation · Kohei Yoshida
- Re: [REVIEW 3-5][PATCH] Fix leap year calculation · Stephan Bergmann
- Re: [REVIEW 3-5][PATCH] Fix leap year calculation · Eike Rathke
  - Re: [REVIEW 3-5, 3-5-1] Fix leap year calculation · Niko Rönkkö
- [PUSHED] Re: [REVIEW 3-5][PATCH] Fix leap year calculation · Michael Stahl
  - Re: [PUSHED] Re: [REVIEW 3-5][PATCH] Fix leap year calculation · Michael Meeks
- Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation · Lionel Elie Mamane
  - Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation · Kevin André
    - Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation · Lionel Elie Mamane
      - Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation · Kevin André
    - Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.