Re: [PATCH] Replace getLength() with isEmpty() where appropriate

Muthu Subramanian K <sumuthu -AT- suse.com>
Mon, 27 Feb 2012 19:27:39 +0530

@Ivan: Thanks! I missed that one.

On 02/27/2012 06:45 PM, Ivan Timofeev wrote:

On 27.02.2012 16:59, Ivan Timofeev wrote:

Hi Christina,

On 27.02.2012 12:22, Chr. Rossmanith wrote:

some more getLength() -> isEmpty() replacements. Would be nice if
someone could review the patch.


at least, aTextHtml and aData from your patch are 'Sequence's, Sequence
has not the isEmpty method IIRC, only the string classes have it.


fixed that now
http://cgit.freedesktop.org/libreoffice/core/commit/?id=c581d33dec47a4c411a034482876543f6357d1e8


Ivan
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Context

[PATCH] Replace getLength() with isEmpty() where appropriate · Chr. Rossmanith
- Re: [Pushed] [PATCH] Replace getLength() with isEmpty() where appropriate · Muthu Subramanian K
- Re: [PATCH] Replace getLength() with isEmpty() where appropriate · Ivan Timofeev
  - Re: [PATCH] Replace getLength() with isEmpty() where appropriate · Ivan Timofeev
    - Re: [PATCH] Replace getLength() with isEmpty() where appropriate · Muthu Subramanian K
  - Re: [PATCH] Replace getLength() with isEmpty() where appropriate · Chr. Rossmanith

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.