Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi,

https://bugs.freedesktop.org/show_bug.cgi?id=31966

This bug was fixed in 3-5, but I didn't propose it for 3-4, and that was confusing to the bug reporter. So, taking into account the simplicity of the patch, I'd like to see it in 3-4. The patch for the "impress" repository is attached.

Sorry if it is insignificant for that branch.

Thanks,
Ivan
From 57acc16017ec7313b047066b1177a088aecaa2ed Mon Sep 17 00:00:00 2001
From: Ivan Timofeev <timofeev.i.s@gmail.com>
Date: Mon, 27 Feb 2012 16:26:39 +0400
Subject: [PATCH] fdo#31966: do not create an empty slide when printing
 handouts

---
 sd/source/ui/view/DocumentRenderer.cxx |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sd/source/ui/view/DocumentRenderer.cxx b/sd/source/ui/view/DocumentRenderer.cxx
index 758e5ed..64cd478 100644
--- a/sd/source/ui/view/DocumentRenderer.cxx
+++ b/sd/source/ui/view/DocumentRenderer.cxx
@@ -1967,8 +1967,8 @@ private:
 
             // Create a printer page when we have found one page for each
             // placeholder or when this is the last (and special) loop.
-            if (aPageIndices.size() == nShapeCount
-                || nIndex==nCount)
+            if (!aPageIndices.empty() &&
+                (aPageIndices.size() == nShapeCount || nIndex == nCount))
             {
                 maPrinterPages.push_back(
                     ::boost::shared_ptr<PrinterPage>(
-- 
1.7.9


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.