Duplicate code: GlyphSet::DrawGlyphs() and GlyphSet::ImplDrawText()

"Chr. Rossmanith" <ChrRossmanith -AT- gmx.de>

Mon, 27 Feb 2012 09:49:34 +0100

Hi,

the method GlyphSet::DrawGlyphs() is nearly a total subset of

GlyphSet::ImplDrawText(). The only difference is the declaration of

OString aGlyphSetName(GetGlyphSetName(*aSet)); <-- DrawGlyphs() vs. OString aGlyphSetName(GetCharSetName(*aSet)); <-- ImplDrawText()

DrawGlyphs() is only rarely used. I'd suggest to add a parameter

bUseGlyphSet to switch between the declarations of aGlyphSetName and

replace the duplicate code in ImplDrawText() with a call to DrawGlyphs().

Or are there reasons for not adding an additional parameter to

DrawGlyphs() ?

You find the source code in vcl/generic/print/glyphset.cxx. Christina

Context

Duplicate code: GlyphSet::DrawGlyphs() and GlyphSet::ImplDrawText() · Chr. Rossmanith

Re: Duplicate code: GlyphSet::DrawGlyphs() and GlyphSet::ImplDrawText() · Michael Meeks

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.