[PATCH] Removed unused code

Bartolomé Sánchez Salado <aliaselbarto -AT- gmail.com>
Sat, 25 Feb 2012 19:59:25 +0100

Hello.

I've removed some unused virtual methods inside backends as Michael
Meeks requested me:

http://www.mail-archive.com/libreoffice@lists.freedesktop.org/msg23796.html

after my first commit:

http://lists.freedesktop.org/archives/libreoffice-commits/2012-February/027928.html

Bartolomé Sánchez.

From 0f07b50a75ff489320f46aa8123ce10548d1a300 Mon Sep 17 00:00:00 2001
From: elbarto <aliaselbarto@gmail.com>
Date: Sat, 25 Feb 2012 19:34:35 +0100
Subject: [PATCH] Removed unused code.

---
 avmedia/source/gstreamer/gstplayer.cxx |   26 ------------------------
 avmedia/source/gstreamer/gstplayer.hxx |    3 --
 avmedia/source/quicktime/player.hxx    |    3 --
 avmedia/source/quicktime/player.mm     |   34 --------------------------------
 avmedia/source/win/player.cxx          |   31 -----------------------------
 avmedia/source/win/player.hxx          |    3 --
 offapi/com/sun/star/media/XPlayer.idl  |   20 ------------------
 7 files changed, 0 insertions(+), 120 deletions(-)

diff --git a/avmedia/source/gstreamer/gstplayer.cxx b/avmedia/source/gstreamer/gstplayer.cxx
index fa1dcbd..ee54965 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -396,32 +396,6 @@ double SAL_CALL Player::getMediaTime(  )
 
 // ------------------------------------------------------------------------------
 
-void SAL_CALL Player::setStopTime( double /*fTime*/ )
-    throw (uno::RuntimeException)
-{
-    // TODO implement
-}
-
-// ------------------------------------------------------------------------------
-
-double SAL_CALL Player::getStopTime(  )
-    throw (uno::RuntimeException)
-{
-    // Get the time at which to stop
-
-    return 0;
-}
-
-// ------------------------------------------------------------------------------
-
-void SAL_CALL Player::setRate( double /*fRate*/ )
-    throw (uno::RuntimeException)
-{
-    // TODO set the window rate
-}
-
-// ------------------------------------------------------------------------------
-
 double SAL_CALL Player::getRate(  )
     throw (uno::RuntimeException)
 {
diff --git a/avmedia/source/gstreamer/gstplayer.hxx b/avmedia/source/gstreamer/gstplayer.hxx
index 0e04d67..b5d7d83 100644
--- a/avmedia/source/gstreamer/gstplayer.hxx
+++ b/avmedia/source/gstreamer/gstplayer.hxx
@@ -62,9 +62,6 @@ public:
     virtual double SAL_CALL getDuration(  ) throw (::com::sun::star::uno::RuntimeException);
     virtual void SAL_CALL setMediaTime( double fTime ) throw 
(::com::sun::star::uno::RuntimeException);
     virtual double SAL_CALL getMediaTime(  ) throw (::com::sun::star::uno::RuntimeException);
-    virtual void SAL_CALL setStopTime( double fTime ) throw 
(::com::sun::star::uno::RuntimeException);
-    virtual double SAL_CALL getStopTime(  ) throw (::com::sun::star::uno::RuntimeException);
-    virtual void SAL_CALL setRate( double fRate ) throw (::com::sun::star::uno::RuntimeException);
     virtual double SAL_CALL getRate(  ) throw (::com::sun::star::uno::RuntimeException);
     virtual void SAL_CALL setPlaybackLoop( sal_Bool bSet ) throw 
(::com::sun::star::uno::RuntimeException);
     virtual sal_Bool SAL_CALL isPlaybackLoop(  ) throw (::com::sun::star::uno::RuntimeException);
diff --git a/avmedia/source/quicktime/player.hxx b/avmedia/source/quicktime/player.hxx
index da9bbfc..ec795fd 100644
--- a/avmedia/source/quicktime/player.hxx
+++ b/avmedia/source/quicktime/player.hxx
@@ -59,9 +59,6 @@ public:
     virtual double SAL_CALL getDuration(  ) throw (::com::sun::star::uno::RuntimeException);
     virtual void SAL_CALL setMediaTime( double fTime ) throw 
(::com::sun::star::uno::RuntimeException);
     virtual double SAL_CALL getMediaTime(  ) throw (::com::sun::star::uno::RuntimeException);
-    virtual void SAL_CALL setStopTime( double fTime ) throw 
(::com::sun::star::uno::RuntimeException);
-    virtual double SAL_CALL getStopTime(  ) throw (::com::sun::star::uno::RuntimeException);
-    virtual void SAL_CALL setRate( double fRate ) throw (::com::sun::star::uno::RuntimeException);
     virtual double SAL_CALL getRate(  ) throw (::com::sun::star::uno::RuntimeException);
     virtual void SAL_CALL setPlaybackLoop( sal_Bool bSet ) throw 
(::com::sun::star::uno::RuntimeException);
     virtual sal_Bool SAL_CALL isPlaybackLoop(  ) throw (::com::sun::star::uno::RuntimeException);
diff --git a/avmedia/source/quicktime/player.mm b/avmedia/source/quicktime/player.mm
index e4550a0..15c39e9 100644
--- a/avmedia/source/quicktime/player.mm
+++ b/avmedia/source/quicktime/player.mm
@@ -226,40 +226,6 @@ double SAL_CALL Player::getMediaTime(  )
 
 // ------------------------------------------------------------------------------
 
-void SAL_CALL Player::setStopTime( double fTime )
-    throw (uno::RuntimeException)
-{
-    OSL_TRACE ("Player::setStopTime %f", fTime);
-
-    mnStopTime = fTime;
-}
-
-// ------------------------------------------------------------------------------
-
-double SAL_CALL Player::getStopTime(  )
-    throw (uno::RuntimeException)
-{
-    double fRet = mnStopTime;
-
-    return fRet;
-}
-
-// ------------------------------------------------------------------------------
-
-void SAL_CALL Player::setRate( double fRate )
-    throw (uno::RuntimeException)
-{
-    OSL_TRACE ("Player::setRate");
-
-    // Quicktime: 0 = stop, 1 = normal speed, 2 = double speed, -1 = normal speed backwards
-    if ( mpMovie )
-    {
-        [mpMovie setRate: fRate];
-    }
-}
-
-// ------------------------------------------------------------------------------
-
 double SAL_CALL Player::getRate(  )
     throw (uno::RuntimeException)
 {
diff --git a/avmedia/source/win/player.cxx b/avmedia/source/win/player.cxx
index c2dea25..338db97 100644
--- a/avmedia/source/win/player.cxx
+++ b/avmedia/source/win/player.cxx
@@ -305,37 +305,6 @@ double SAL_CALL Player::getMediaTime(  )
 
 // ------------------------------------------------------------------------------
 
-void SAL_CALL Player::setStopTime( double fTime )
-    throw (uno::RuntimeException)
-{
-    if( mpMP  )
-        mpMP->put_StopTime( fTime );
-}
-
-// ------------------------------------------------------------------------------
-
-double SAL_CALL Player::getStopTime(  )
-    throw (uno::RuntimeException)
-{
-    REFTIME aRefTime( 0.0 );
-
-    if( mpMP  )
-        mpMP->get_StopTime( &aRefTime );
-
-    return aRefTime;
-}
-
-// ------------------------------------------------------------------------------
-
-void SAL_CALL Player::setRate( double fRate )
-    throw (uno::RuntimeException)
-{
-    if( mpMP  )
-        mpMP->put_Rate( fRate );
-}
-
-// ------------------------------------------------------------------------------
-
 double SAL_CALL Player::getRate(  )
     throw (uno::RuntimeException)
 {
diff --git a/avmedia/source/win/player.hxx b/avmedia/source/win/player.hxx
index 7f87511..debdecc 100644
--- a/avmedia/source/win/player.hxx
+++ b/avmedia/source/win/player.hxx
@@ -75,9 +75,6 @@ public:
     virtual double SAL_CALL getDuration(  ) throw (::com::sun::star::uno::RuntimeException);
     virtual void SAL_CALL setMediaTime( double fTime ) throw 
(::com::sun::star::uno::RuntimeException);
     virtual double SAL_CALL getMediaTime(  ) throw (::com::sun::star::uno::RuntimeException);
-    virtual void SAL_CALL setStopTime( double fTime ) throw 
(::com::sun::star::uno::RuntimeException);
-    virtual double SAL_CALL getStopTime(  ) throw (::com::sun::star::uno::RuntimeException);
-    virtual void SAL_CALL setRate( double fRate ) throw (::com::sun::star::uno::RuntimeException);
     virtual double SAL_CALL getRate(  ) throw (::com::sun::star::uno::RuntimeException);
     virtual void SAL_CALL setPlaybackLoop( sal_Bool bSet ) throw 
(::com::sun::star::uno::RuntimeException);
     virtual sal_Bool SAL_CALL isPlaybackLoop(  ) throw (::com::sun::star::uno::RuntimeException);
diff --git a/offapi/com/sun/star/media/XPlayer.idl b/offapi/com/sun/star/media/XPlayer.idl
index 059a4c9..121b800 100644
--- a/offapi/com/sun/star/media/XPlayer.idl
+++ b/offapi/com/sun/star/media/XPlayer.idl
@@ -77,26 +77,6 @@ interface XPlayer
      */
     double getMediaTime();
 
-    /** sets the time at which to stop reading the stream.
-
-        @param fTime
-            the time at which to stop reading the stream in seconds
-     */
-    void setStopTime( [in] double fTime );
-
-    /** gets the time at which the stream will stop. The result
-        is not guaranteed if no stop time has been set.
-     */
-    double getStopTime();
-
-    /** sets the speed of the stream reading relatively to the normal
-        speed.
-
-        @param fRate
-            the stream reading rate. <code>1.0</code> means normal speed.
-     */
-    void setRate( [in] double fRate );
-
     /** gets the speed of the stream reading relatively to the normal
         reading.
 
-- 
1.7.2.5

Context

[PATCH] Removed unused code · Bartolomé Sánchez Salado
- [PUSHED] Removed unused code · Michael Meeks
- Re: [PATCH] Removed unused code · Muthu Subramanian K

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.