Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Thu, 2012-02-23 at 13:03 +0000, Michael Meeks wrote:
      Any thoughts Caolan ?

callcatcher is right, this is a *pure* virtual, i.e. the = 0 of

virtual void dispose() = 0;

Everything that inherits from it has to implement a ::dispose so there's
a virtual method slot created for "dispose" and everything that inherits
from it has to implement a ::dispose which'll be a virtual method.

Typically you don't provide an implementation of a pure virtual, because
you're forcing the inheritors to provide one, but if you *do* then that
implementation itself isn't actually a virtual, and if you want to call
it you have to explicitly call it.  

So, in this case, no one has explicitly called the baseclass pure
virtual implementation, so the bodies can go, but to be safe the pure
virtual declarations themselves should stay, i.e.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=84cc2688f429ef915810a3799f46ae98293096a6

C.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.