Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index



On Tue, 2012-02-21 at 18:28 +0100, Petr Mladek wrote:
we needed to push the huge diff in dmake/configure to fix build on
windows, see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ad7f850e829a4be91725b6b7086f6a871a84bae5

        Ah - right; what a pain.

The configure.in is pretty easy, so it should be safe to remove all the
generated files from git and generate them during build.

        So - the diff is not -so- huge, by the standards of patches we push
daily, so if this is not going to happen weekly it seems ok to me :-)

Another solution would be to call "autoreconf -f -a" instead of
aclocal/autoheader/automake/autoconf, keep the old files in git and just
ignore all changes in the Makefile.in/acinclude.m4/config.sub and other
files.

        I guess - we require autotools anyway for autogen.sh to run, so ...
sounds like the best fix for master, but for -3-5 checking it in seems
reasonable ?

        How does that sound ?

        ATB,

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.