[REVIEWED][3-5] misc fixes for -3-5

Hi Michael,

On Sat, 2012-02-18 at 00:19 +0100, Michael Stahl wrote:
> some misc commits, mostly crashes fixed while loading ~2000 presumed
> ODT documents (looking at actual patches reveals expecting people to set
> bug attachment mime types correctly is unrealistic), proposed for
> libreoffice-3-5:

        Nice work ! :-)

> http://cgit.freedesktop.org/libreoffice/core/commit/?id=cd24d2524f2c2da51f982015f1b027003b192808
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=43cb934dda9af45a83748c775f274bbd0fdcd67a

        Lovely, pushed.

> boost crash (don't know if that happens in product builds as well):
> this basically syncs the binfilter code with core:
>
> http://cgit.freedesktop.org/libreoffice/binfilter/commit/?id=508835a5ea8d385b3a740b769d75cdd4c3362809

        picked.

> gdb thingy:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=89b68f682e40f1bdc6c967bf38308504fae70d82

        ditto - no harm for the product to be able to debug it better :-)

> assertions triggered by silly code:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=6c3e8f9d19a0392a817c1b5692421ed0972a3b7e
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=c1f723fd53e8c41b80285d11a149e0044f580e2f

        Fun; pushed.

> pyuno valgrind:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=29177b1d04b845e8e6bf8edc8beb34b76a95d9c3

        Urk, that looks really flaky, the code is somewhat amazing there -
surely we're not creating a new thread for each python object that is
unref'd ? Indeed the premise seems to be that python should be using a
recursive mutex but that's madness surely ;-) ... Do we not attach and
detach the python mutex as/when we call in and out of the python
interpreter ourselves ? or ... well nasty anyhow. Patch doesn't look as
if it can do any harm though, so I pushed it ;-)

> crash in Impress accessibility code:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=cdfa3bd5e4c62dc88158a4c6c4908404baf1f529
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=e72e8dcd332474321439eb266528eb7e5fc8809f

        Neither fills me with joy - but ... ;-) I'm still reeling from the
python code so ... pushed these too ;-)

        Thanks for the patch set !

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot