Hi Tim,
On Fri, 2012-02-17 at 23:40 +0000, Tim Retout wrote:
This patch series removes several versions of Perl modules named
<foo>::existence - the functions can be reimplemented with the "grep"
keyword.
Right :-)
Some error messages may change in patch 9, but the error message logic
in get_specified_file_by_name was not clear to me, (even checking the
context of CWS nativefixer6 that introduced it):
That's fine, no one is parsing the error messages from
make_installer.pl - feel free to improve them any way you like.
Oh, and there should be two new unit tests in there, too - not
complete code coverage by any means, but they were useful during
development to prove that I wasn't breaking the tested functions.
Right - I guess we need to do some gnumake research to work out how to
hook them up.
Now that I've done such a huge patch series, I wonder if there was a
better way to approach this to make it easier to review... :(
Given that it all looks beautiful & works nicely AFAICS, I wouldn't
worry :-)
Thanks,
Michael.
--
michael.meeks@suse.com <><, Pseudo Engineer, itinerant idiot
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.