On Wed, Feb 15, 2012 at 01:55:34PM +0100, Lionel Elie Mamane wrote:
2) Signed integers and unsigned integers never compare equal. But an
unsigned integer compares equal to the corresponding float...
Errr... They obviously should?
I misread the code... Need coffee. integers never compare equal to
floats, they don't even compare equal to the corresponding integer of
different size? E.g. 5 as a 16-bit integer is not equal to 5 as a
32-bit integer.
I'm suddenly more shy about changing that... The intended semantics
seem different, but OTOH,
frm::OListBoxModel::translateDbColumnToControlValue clearly expects
wider semantics (more things are equal). Dunno about other callers.
Mainly, I see no reason why floats of different subtypes should
compare equal, but not integers.
Thinking about it.
--
Lionel
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.