Re: [Libreoffice-commits] "Remove unused VolumeDevice functions and related code"

On Tue, Feb 14, 2012 at 06:18:52PM +0100, Stephan Bergmann wrote:
> On 02/05/2012 09:52 PM, François Tigeot wrote:
> >     Remove unused VolumeDevice functions and related code
> [...]
> > diff --git a/sal/util/sal.map b/sal/util/sal.map
> > index 472ea8f..338854d 100644
> > --- a/sal/util/sal.map
> > +++ b/sal/util/sal.map
> > @@ -443,8 +443,6 @@ UDK_3_0_0 {
> >          osl_getSystemTimeFromLocalTime;
> >          osl_getAbsoluteFileURL;
> >
> > -        osl_unmountVolumeDevice;
> > -        osl_automountVolumeDevice;
> >          osl_releaseVolumeDeviceHandle;
> >          osl_getVolumeDeviceMountPath;
> >          osl_acquireVolumeDeviceHandle;
>
> I'm not sure this change is a good idea, given that it incompatibly
> changes the stable URE interface.  (Arguably, those functions are of
> ~no use, but changing existing sections of sal.map post-facto always
> feels like a no-no to me.)

I may have been a bit too enthusiastic with sal.map; feel free to add
the entries back if you think they are needed.

The actual functions are of course useless; that code was related to
floppy handling (stardesktop remains ?) and only fully implemented for
Solaris and maybe Linux.

-- 
Francois Tigeot