Re: [PATCH] [PUSHED,modified] Moving misplaced Compatibility options from ScDocOptions to ScAppOptions

Hi Albert,

On Sun, 2012-02-12 at 22:28 +0100, Albert Thuswaldner wrote:

> I have worked with converting the Formula options. However, while
> doing the work and looking through the code I have started to question
> if this conversion is such a good idea in this case?
>
> Without knowing the exact difference between AppOptions and DocOptions
> it is this this bit that worries me:
>
> http://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/impop.cxx#158
>
> Seems that the excel import filter is setting some of these formula
> options, better to keep those as DocOptions  then?

Sorry, I didn't explain the goal very well. :-P

You just need to move the options that are in the Formula options page,
which is to say move those that are below bFormulaRegexEnabled in the
ScDocOptions declaration.

IOW, we have 5 options to move: 

bUseEnglishFuncName
eFormulaGrammar
aFormulaSepArg
aFormulaSepArrayRow
aFormulaSepArrayCol

The rest should stay in ScDocOptions.  And bFormulaRegexEnable is indeed
a document-specific option as you can see in the code you referenced in
your mail.

Best,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc