Re: [REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt

Jan Holesovsky <kendy -AT- suse.cz>
Mon, 13 Feb 2012 13:15:16 +0100

Hi Michael,

Michael Meeks píše v Po 13. 02. 2012 v 11:59 +0000:

Returning a 'I was unable create a cursor' value via throwing runtime
exception [in SwXFootnote::createTextCursorByRange()] is not really
efficient ;-) - but I have no idea what I might break by changing that,
so I just catch the exception in the code that already somehow counts on
the possibility that the call fails anyway.  This way, the filter fails
nicely, with our "favorite" 'General Input/Output Error.'


      You have my ack for -3-5 :-) any chance you can push it ?


Done, thank you for the review!

Regards,
Kendy

Context

[REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt · Jan Holesovsky
- Re: [REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt · Michael Meeks
  - Re: [REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt · Jan Holesovsky
    - [PUSHED 3-5] Re: [REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt · Jan Holesovsky
- Re: [PUSHED][3-4,3-5][REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.