Hi Noel,
On 10.02.2012 13:42, Noel Grandin wrote:
Convert tools/table.hxx usage in editeng/source/editeng/editdoc.hxx to
boost::ptr_map
Your patch looks good to me. But... let's look at the usages of the
SvxFontTable class. All of them are in editeng/source/editeng/impedit4.cxx.
ImpEditEngine::WriteRTF:
SvxFontTable aFontTable;
aFontTable.Insert( 0, ... );
aFontTable.Insert( 1, ... );
aFontTable.Insert( 2, ... );
Ok, keys are 0, 1, 2.
aFontTable.Insert( aFontTable.Count(), ... );
Keys will be 3, 4, 5 and so on. And there are no other calls of Insert.
Thus, no real need of a map, we can use a vector, and treat positions of
elements as ex-keys. So, I'd suggest to remove SvxFontTable wrapper,
directly replacing it with vector.
Have you something against? :)
Best Regards,
Ivan
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.