Contribution under LGPLv3+ / MPL.
Since this is my first contribution, I have a question.
I grepped for the removed stuff using pss[1], a Python clone of the
more famous ack[2] and I told the tool to only grep in C and C++
files, otherwise it takes a lot longer. These extensions are then
searched: .c .cpp .cc .cxx .m .hpp .hh .h .hxx. How sure can I be that
this covers all their possible uses in LibreOffice code base? Could
it be that some Java code is calling those methods via JNI for
example?
Thanks!
[1] https://bitbucket.org/eliben/pss/overview
[2] http://betterthangrep.com/
Catalin Iacob (3):
Remove unused code in XMLSignatureHelper
Remove unused code in XSecController
Remove unused code in XMLTextImportHelper
unusedcode.easy | 12 ----
xmloff/inc/xmloff/txtimp.hxx | 7 --
xmloff/source/text/txtimp.cxx | 36 -----------
xmlsecurity/inc/xmlsecurity/xmlsignaturehelper.hxx | 11 ----
xmlsecurity/source/helper/xmlsignaturehelper.cxx | 47 --------------
xmlsecurity/source/helper/xsecctl.cxx | 64 --------------------
xmlsecurity/source/helper/xsecctl.hxx | 10 ---
xmlsecurity/source/helper/xsecsign.cxx | 30 ---------
8 files changed, 0 insertions(+), 217 deletions(-)
--
1.7.8.3
Context
- [PATCH 0/3] Code removal, first contribution · Catalin Iacob
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.