AccessibleStaticTextBase.cxx

Eike Rathke <erack -AT- redhat.com>
Wed, 1 Feb 2012 16:17:51 +0100

Hi julien2412,

On Tuesday, 2012-01-31 13:36:41 -0800, julien2412 wrote:

Should it be just replaced by this :
          if( aTextSegment.SegmentStart != -1 &&
               aTextSegment.SegmentEnd != -1 )

or is it not so obvious ?


If only SegmentEnd was -1 and SegmentStart was not, then the state of
that segement would had been dubious and adding an offset to both
wouldn't make sense I think. So yes, this seems to be the solution.
Can't be worse than it was where it ignored SegmentEnd and looked like
a copy&paste error.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgp_zk_yB6P1H.pgp
Description: PGP signature

Context

[Libreoffice] Same expression on both sides of '&&' on editeng/source/accessibility/AccessibleStaticTextBase.cxx · julien2412
- Re: [Libreoffice] Same expression on both sides of '&&' on editeng/source/accessibility/AccessibleStaticTextBase.cxx · Eike Rathke
  - [Libreoffice] [PUSHED] Re: Same expression on both sides of '&&' on editeng/source/accessibility/AccessibleStaticTextBase.cxx · julien2412

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.