Re: [Libreoffice] [PATCH] [REVIEW:3-5] fdo#45453 cannot execute any query if database does not support booleans

Jan Holesovsky <kendy -AT- suse.cz>
Wed, 01 Feb 2012 11:32:08 +0100

Hi Lionel,

On 2012-01-31 at 23:14 +0100, Lionel Elie Mamane wrote:

Attached patch fixes fdo#45453, which breaks datasheet display of all
queries/tables (with more than twice the number of rows than fit on
screen), if the database system does not properly support boolean
types.

The original bug report is about Firebird SQL.

Please apply to libreoffice-3-5.


From what I see, the change is local - ie. it is our code that
introduces the boolean, and also our checks for that; and your patch
changes that to setting byte, and checking for 0/1.

This looks fine, and really, according to what I've googled, much better
than using boolean that seems to be quite implementation specific.

Pushed to -3-5:

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=acc36a60de35cdc07e41d1838738b7603e87cf4d

Regards,
Kendy

Context

[Libreoffice] [PATCH] [REVIEW:3-5] fdo#45453 cannot execute any query if database does not support booleans · Lionel Elie Mamane
- Re: [Libreoffice] [PATCH] [REVIEW:3-5] fdo#45453 cannot execute any query if database does not support booleans · Noel Power
  - Re: [Libreoffice] [PATCH] [REVIEW:3-5] fdo#45453 cannot execute any query if database does not support booleans · Muthu Subramanian K
    - Re: [Libreoffice] [PUSHED:3-5-0] fdo#45453 cannot execute any query if database does not support booleans · Petr Mladek
- Re: [Libreoffice] [PATCH] [REVIEW:3-5] fdo#45453 cannot execute any query if database does not support booleans · Jan Holesovsky

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.