Re: [Libreoffice] [PATCH] unusedcode.easy: Removed unused code (basegfx)

Hi Alexander
After applying this doesn't compile for me, at least in a couple of 
instances there appear to be getEmptyTuple methods still referenced in 
the code ( e.g. b32point.hxx:122 ), I knocked out a couple of those but 
then some errors started appearing in some of the cxx files. Now before 
I applied this I did scan the diff of unusedcode.easy against the 
changes in the patch and whilst they appeared to match in my quick scan 
it I guess that perhaps you have knocked out the wrong versions of some 
of these ( or perhaps there is a callcatcher special case at work ) 
or... even I have somehow missed something. Note: I had to copy and 
paste the patch content from the mail ( would be good in future to 
attach the patch ) perhaps I missed something there ( but a git diff 
--stat produced something looking quite like whats below ). Could you 
please check this again?

Noel

On 31/01/12 12:53, Alexander Bergmann wrote:
> ---
>   basegfx/inc/basegfx/matrix/b2dhommatrixtools.hxx |    3 -
>   basegfx/inc/basegfx/polygon/b2dpolygon.hxx       |   20 --------
>   basegfx/inc/basegfx/polygon/b3dpolygon.hxx       |    3 -
>   basegfx/inc/basegfx/polygon/b3dpolypolygon.hxx   |    3 -
>   basegfx/inc/basegfx/range/b1drange.hxx           |    8 ---
>   basegfx/inc/basegfx/range/b2drange.hxx           |    6 --
>   basegfx/inc/basegfx/range/b3drange.hxx           |    8 ---
>   basegfx/inc/basegfx/tools/canvastools.hxx        |   10 ----
>   basegfx/inc/basegfx/tools/unopolypolygon.hxx     |    3 -
>   basegfx/inc/basegfx/tuple/b2i64tuple.hxx         |    2 -
>   basegfx/inc/basegfx/tuple/b2ituple.hxx           |    2 -
>   basegfx/inc/basegfx/tuple/b3dtuple.hxx           |    7 ---
>   basegfx/inc/basegfx/tuple/b3i64tuple.hxx         |    2 -
>   basegfx/inc/basegfx/tuple/b3ituple.hxx           |    2 -
>   basegfx/inc/basegfx/vector/b2dvector.hxx         |    8 ---
>   basegfx/inc/basegfx/vector/b2ivector.hxx         |   14 -----
>   basegfx/source/matrix/b2dhommatrixtools.cxx      |   26 ----------
>   basegfx/source/polygon/b2dpolygon.cxx            |   24 ---------
>   basegfx/source/polygon/b3dpolygon.cxx            |    5 --
>   basegfx/source/polygon/b3dpolypolygon.cxx        |   17 -------
>   basegfx/source/range/b1drange.cxx                |   18 -------
>   basegfx/source/range/b2drange.cxx                |    7 ---
>   basegfx/source/range/b3drange.cxx                |   29 -----------
>   basegfx/source/tools/canvastools.cxx             |   56 ----------------------
>   basegfx/source/tools/unopolypolygon.cxx          |    5 --
>   basegfx/source/tuple/b2i64tuple.cxx              |    5 --
>   basegfx/source/tuple/b2ituple.cxx                |    5 --
>   basegfx/source/tuple/b3dtuple.cxx                |    6 --
>   basegfx/source/tuple/b3i64tuple.cxx              |    4 --
>   basegfx/source/tuple/b3ituple.cxx                |    4 --
>   basegfx/source/vector/b2dvector.cxx              |    8 ---
>   basegfx/source/vector/b2ivector.cxx              |    6 --
>   unusedcode.easy                                  |   25 ----------
>   33 files changed, 0 insertions(+), 351 deletions(-)