Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Mon, 30 Jan 2012 22:35:46 +0100, Kohei Yoshida <kohei.yoshida@suse.com> wrote:

Hi,

I'd like

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2b11f4fd79dce4116badb0ecf6477546ca5d0d4

cherry-picked to the 3-5 branch.  It is probably too late for change
like this to be in the 3-5-0 branch so I won't even try.


---- SNIP ----

The problem is, this counter is
unsigned 16-bit integer, and as soon as it goes above 65535 it rolls
back to zero, and eventually the token instance gets deleted
prematurely.


this issue sounds similar to https://issues.apache.org/ooo/show_bug.cgi?id=87672 Bug 87672 - autocorrect limit. acor.dat with entry 65535: Loop and/or loss of acor data



As an aside, although it's not necessary for this fix, on master we
should probably use unsigned 32-bit integer to store reference counter
for this just to future-proof ourselves.  16-bit integer seems a bit too
small for this purpose.

Regards,

Kohei



I don't know if tha autocorrect is your area,
anyway do you think that is technically possible to replace in the future those 16-bit .xml autocorrect files with 32-bit files in order to increase the number
of autocorrect entries?


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.